djsundog/obj2gltf
1
0
Fork 0
mirror of https://github.com/CesiumGS/obj2gltf.git synced 2024-11-27 10:30:16 -05:00
Code Issues Packages Projects Releases Wiki Activity

Remove obsolete buffer limit check

Browse Source
This commit is contained in:
Chris Cooper 2024-08-29 15:42:03 +10:00
parent ce0c36e281
commit 1468de3f00
2 changed files with 2 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/writeGltf.js
View File

@ -162,13 +162,6 @@ function writeEmbeddedBuffer(gltf) {
const buffer = gltf.buffers[0]; const buffer = gltf.buffers[0];
const source = buffer.extras._obj2gltf.source; const source = buffer.extras._obj2gltf.source;
// Buffers larger than ~192MB cannot be base64 encoded due to a NodeJS limitation. Source: https://github.com/nodejs/node/issues/4266
if (source.length > 201326580) {
throw new RuntimeError(
"Buffer is too large to embed in the glTF. Use the --separate flag instead.",
);
}
buffer.uri = `data:application/octet-stream;base64,${source.toString( buffer.uri = `data:application/octet-stream;base64,${source.toString(
"base64", "base64",
)}`; )}`;

2
package.json
View File

@ -1,6 +1,6 @@
{ {
"name": "obj2gltf", "name": "obj2gltf",
"version": "3.1.6", "version": "3.1.7",
"description": "Convert OBJ model format to glTF", "description": "Convert OBJ model format to glTF",
"license": "Apache-2.0", "license": "Apache-2.0",
"contributors": [ "contributors": [