From 1468de3f0000e0aa030a1adbfa43354bdd5cf513 Mon Sep 17 00:00:00 2001 From: Chris Cooper Date: Thu, 29 Aug 2024 15:42:03 +1000 Subject: [PATCH] Remove obsolete buffer limit check --- lib/writeGltf.js | 7 ------- package.json | 4 ++-- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/lib/writeGltf.js b/lib/writeGltf.js index 22ad3ad..6afb680 100644 --- a/lib/writeGltf.js +++ b/lib/writeGltf.js @@ -162,13 +162,6 @@ function writeEmbeddedBuffer(gltf) { const buffer = gltf.buffers[0]; const source = buffer.extras._obj2gltf.source; - // Buffers larger than ~192MB cannot be base64 encoded due to a NodeJS limitation. Source: https://github.com/nodejs/node/issues/4266 - if (source.length > 201326580) { - throw new RuntimeError( - "Buffer is too large to embed in the glTF. Use the --separate flag instead.", - ); - } - buffer.uri = `data:application/octet-stream;base64,${source.toString( "base64", )}`; diff --git a/package.json b/package.json index ccb1897..1c90348 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "obj2gltf", - "version": "3.1.6", + "version": "3.1.7", "description": "Convert OBJ model format to glTF", "license": "Apache-2.0", "contributors": [ @@ -72,4 +72,4 @@ "bin": { "obj2gltf": "./bin/obj2gltf.js" } -} +} \ No newline at end of file