djsundog/tootlab-mastodon
1
0
Fork 0
mirror of https://github.com/glitch-soc/mastodon.git synced 2024-11-27 02:24:03 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix keyboard navigation changing settings in App settings

Browse Source 
When using keyboard navigation `onBlur` and `onChange` on radio buttons caused settings to be changed.

Uses `onClick` instead and replaces `onChange` with a noop to prevent react from complaining.

Signed-off-by: Plastikmensch <plastikmensch@users.noreply.github.com>
This commit is contained in:
Plastikmensch 2023-11-05 05:27:15 +01:00
parent 3b49b5a880
commit dc2aa6ae82
No known key found for this signature in database
GPG Key ID: 96381D586F4A6077
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/javascript/flavours/glitch/features/local_settings/page/item/index.jsx
View File

@ -33,8 +33,10 @@ export default class LocalSettingsPageItem extends PureComponent {
else onChange(item, target.checked);
};
noop = () => {};
render () {
const { handleChange } = this;
const { handleChange, noop } = this;
const { settings, item, id, inputProps, options, children, dependsOn, dependsOnNot, placeholder, disabled } = this.props;
let enabled = !disabled;
@ -60,8 +62,8 @@ export default class LocalSettingsPageItem extends PureComponent {
name={id}
id={optionId}
value={opt.value}
onBlur={handleChange}
onChange={handleChange}
onClick={handleChange}
onChange={noop}
checked={currentValue === opt.value}
disabled={!enabled}
{...inputProps}