djsundog
/
obj2gltf
mirror of https://github.com/CesiumGS/obj2gltf.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #240 from CesiumGS/remove-sampler-filter 

Remove minFilter and magFilter
This commit is contained in:
Ian Lilley 2021-08-01 17:18:48 -07:00 committed by GitHub
parent 2634c25e33 4270358310
commit 3283239024
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGES.md
View File

@ -1,6 +1,10 @@
Change Log Change Log
========== ==========
### 3.?.? - 2021-??-??
* Removed `minFilter` and `magFilter` from generated samplers so that runtime engines can use their preferred texture filtering. [#240](https://github.com/CesiumGS/obj2gltf/pull/240)
### 3.1.1 - 2021-06-22 ### 3.1.1 - 2021-06-22
* Fixed security warnings by updating outdated npm dependencies. [#254](https://github.com/CesiumGS/obj2gltf/pull/254) * Fixed security warnings by updating outdated npm dependencies. [#254](https://github.com/CesiumGS/obj2gltf/pull/254)

2
lib/createGltf.js
View File

@ -89,8 +89,6 @@ function createGltf(objData, options) {
if (gltf.images.length > 0) { if (gltf.images.length > 0) {
gltf.samplers.push({ gltf.samplers.push({
magFilter : WebGLConstants.LINEAR,
minFilter : WebGLConstants.NEAREST_MIPMAP_LINEAR,
wrapS : WebGLConstants.REPEAT, wrapS : WebGLConstants.REPEAT,
wrapT : WebGLConstants.REPEAT wrapT : WebGLConstants.REPEAT
}); });