54d97251fe
While checking whether we can enable -Wimplicit-fallthrough, I encountered
a diagnostic in mp_binary_set_val_array_from_int which led to discovering
the following bug:
```
>>> struct.pack("xb", 3)
b'\x03\x03'
```
That is, the next value (3) was used as the value of a padding byte, while
standard Python always fills "x" bytes with zeros. I initially thought
this had to do with the unintentional fallthrough, but it doesn't.
Instead, this code would relate to an array.array with a typecode of
padding ('x'), which is ALSO not desktop Python compliant:
```
>>> array.array('x', (1, 2, 3))
array('x', [1, 0, 0])
```
Possibly this is dead code that used to be shared between struct-setting
and array-setting, but it no longer is.
I also discovered that the argument list length for struct.pack
and struct.pack_into were not checked, and that the length of binary data
passed to array.array was not checked to be a multiple of the element
size.
I have corrected all of these to conform more closely to standard Python
and revised some tests where necessary. Some tests for micropython-specific
behavior that does not conform to standard Python and is not present
in CircuitPython was deleted outright.
22 lines
365 B
Plaintext
22 lines
365 B
Plaintext
SyntaxError
|
|
AttributeError
|
|
TypeError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
TypeError, ValueError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
NotImplementedError
|
|
AttributeError
|
|
TypeError
|
|
A.foo
|
|
AttributeError
|