circuitpython

djsundog/circuitpython

Fork 0

Commit Graph

Author	SHA1	Message	Date
David Lechner	d5181034f2	py/bc: Fix checking for duplicate kwargs. The code was already checking for duplicate kwargs for named parameters but if `kwargs` was given as a parameter, it did not check for multiples of the same argument name. This fixes the issue by adding an addition test to catch duplicates and adds a test to exercise the code. Fixes issue #10083. Signed-off-by: David Lechner <david@pybricks.com>	2022-11-28 11:23:22 +11:00
Damien George	3280788195	py/runtime: Check that keys in dicts passed as args are strings. Prior to this patch the code would crash if a key in a dict was anything other than a str or qstr. This is because mp_setup_code_state() assumes that keys in kwargs are qstrs (for efficiency). Thanks to @jepler for finding the bug.	2018-03-30 11:13:32 +11:00
Damien George	539681fffd	tests: Rename test scripts, changing - to _ for consistency. From now on, all new tests must use underscore. Addresses issue #727.	2014-07-05 06:14:29 +01:00

Author

SHA1

Message

Date

David Lechner

d5181034f2

py/bc: Fix checking for duplicate **kwargs.

The code was already checking for duplicate kwargs for named parameters but
if `**kwargs` was given as a parameter, it did not check for multiples of
the same argument name.

This fixes the issue by adding an addition test to catch duplicates and
adds a test to exercise the code.

Fixes issue #10083.

Signed-off-by: David Lechner <david@pybricks.com>

2022-11-28 11:23:22 +11:00

Damien George

3280788195

py/runtime: Check that keys in dicts passed as ** args are strings.

Prior to this patch the code would crash if a key in a ** dict was anything
other than a str or qstr.  This is because mp_setup_code_state() assumes
that keys in kwargs are qstrs (for efficiency).

Thanks to @jepler for finding the bug.

2018-03-30 11:13:32 +11:00

Damien George

539681fffd

tests: Rename test scripts, changing - to _ for consistency.

From now on, all new tests must use underscore.

Addresses issue #727.

2014-07-05 06:14:29 +01:00

3 Commits