Add dirty rectangle tracking to Shape display element

This commit is contained in:
Kevin Matocha 2020-09-04 14:15:15 -05:00
parent d224183a7e
commit f7714649ee
3 changed files with 86 additions and 1 deletions

View File

@ -49,10 +49,16 @@ void common_hal_displayio_shape_construct(displayio_shape_t *self, uint32_t widt
self->half_height = height;
self->data = m_malloc(height * sizeof(uint32_t), false);
//for (uint16_t i = 0; i < height; i++) {
for (uint16_t i = 0; i <= height; i++) {
self->data[2 * i] = 0;
self->data[2 * i + 1] = width;
}
self->dirty_area.x1=0;
self->dirty_area.x2=width;
self->dirty_area.y1=0;
self->dirty_area.y2=height;
}
void common_hal_displayio_shape_set_boundary(displayio_shape_t *self, uint16_t y, uint16_t start_x, uint16_t end_x) {
@ -66,8 +72,58 @@ void common_hal_displayio_shape_set_boundary(displayio_shape_t *self, uint16_t y
if (self->mirror_x && (start_x > half_width || end_x > half_width)) {
mp_raise_ValueError_varg(translate("Maximum x value when mirrored is %d"), half_width);
}
uint16_t lower_x, upper_x;
// find x-boundaries for updating based on current data and start_x, end_x
if (start_x < self->data[2 * y]) {
lower_x = start_x;
} else {
lower_x = self->data[2 * y];
}
if (self->mirror_x) {
upper_x = self->width-lower_x;
} else {
if (end_x > self->data[2 * y + 1]) {
upper_x = end_x + 1;
} else {
upper_x = self->data[2 * y + 1] + 1;
}
}
self->data[2 * y] = start_x;
self->data[2 * y + 1] = end_x;
if (self->dirty_area.x1 == self->dirty_area.x2) { // Dirty region is empty
self->dirty_area.x1=lower_x;
self->dirty_area.x2=upper_x;
self->dirty_area.y1 = y;
if (self->mirror_y) {
self->dirty_area.y2 = self->height-y;
} else {
self->dirty_area.y2 = y+1;
}
} else { // Dirty region is not empty
if (lower_x < self->dirty_area.x1) {
self->dirty_area.x1 = lower_x;
}
if (upper_x > self->dirty_area.x2) {
self->dirty_area.x2 = upper_x;
}
if (y < self->dirty_area.y1) {
self->dirty_area.y1=y;
if (self->mirror_y) { // if y is mirrored and the lower y was updated, the upper y must be updated too
self->dirty_area.y2=self->height-y;
}
}
else {
if ( !self->mirror_y && (y >= self->dirty_area.y2) ) { // y is not mirrored
self->dirty_area.y2=y+1;
}
}
}
}
uint32_t common_hal_displayio_shape_get_pixel(void *obj, int16_t x, int16_t y) {
@ -88,3 +144,21 @@ uint32_t common_hal_displayio_shape_get_pixel(void *obj, int16_t x, int16_t y) {
}
return 1;
}
displayio_area_t* displayio_shape_get_refresh_areas(displayio_shape_t *self, displayio_area_t* tail) {
if (self->dirty_area.x1 == self->dirty_area.x2) {
return tail;
}
self->dirty_area.next = tail;
return &self->dirty_area;
}
void displayio_shape_finish_refresh(displayio_shape_t *self) {
self->dirty_area.x1 = 0;
self->dirty_area.x2 = 0;
}

View File

@ -31,6 +31,7 @@
#include <stdint.h>
#include "py/obj.h"
#include "shared-module/displayio/area.h"
typedef struct {
mp_obj_base_t base;
@ -41,6 +42,10 @@ typedef struct {
uint16_t* data;
bool mirror_x;
bool mirror_y;
displayio_area_t dirty_area;
} displayio_shape_t;
void displayio_shape_finish_refresh(displayio_shape_t *self);
displayio_area_t* displayio_shape_get_refresh_areas(displayio_shape_t *self, displayio_area_t* tail);
#endif // MICROPY_INCLUDED_SHARED_MODULE_DISPLAYIO_SHAPE_H

View File

@ -499,7 +499,7 @@ void displayio_tilegrid_finish_refresh(displayio_tilegrid_t *self) {
if (MP_OBJ_IS_TYPE(self->bitmap, &displayio_bitmap_type)) {
displayio_bitmap_finish_refresh(self->bitmap);
} else if (MP_OBJ_IS_TYPE(self->bitmap, &displayio_shape_type)) {
// TODO: Support shape changes.
displayio_shape_finish_refresh(self->bitmap);
} else if (MP_OBJ_IS_TYPE(self->bitmap, &displayio_ondiskbitmap_type)) {
// OnDiskBitmap changes will trigger a complete reload so no need to
// track changes.
@ -543,6 +543,12 @@ displayio_area_t* displayio_tilegrid_get_refresh_areas(displayio_tilegrid_t *sel
self->full_change = true;
}
}
} else if (MP_OBJ_IS_TYPE(self->bitmap, &displayio_shape_type)) {
displayio_area_t* refresh_area = displayio_shape_get_refresh_areas(self->bitmap, tail);
if (refresh_area != tail) {
displayio_area_copy(refresh_area, &self->dirty_area);
self->partial_change = true;
}
}
self->full_change = self->full_change ||