djsundog/circuitpython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

py/objarray: Disallow slice-assignment to read-only memoryview.

Browse Source 
Also comes with a test for this.  Fixes issue #2904.
This commit is contained in:
Damien George 2017-02-27 16:09:57 +11:00
parent 23ccb3e12e
commit f4a12dca58
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
py/objarray.c
View File

@ -418,6 +418,10 @@ STATIC mp_obj_t array_subscr(mp_obj_t self_in, mp_obj_t index_in, mp_obj_t value
uint8_t* dest_items = o->items; uint8_t* dest_items = o->items;
#if MICROPY_PY_BUILTINS_MEMORYVIEW #if MICROPY_PY_BUILTINS_MEMORYVIEW
if (o->base.type == &mp_type_memoryview) { if (o->base.type == &mp_type_memoryview) {
if ((o->typecode & 0x80) == 0) {
// store to read-only memoryview not allowed
return MP_OBJ_NULL;
}
if (len_adj != 0) { if (len_adj != 0) {
goto compat_error; goto compat_error;
} }

4
tests/basics/memoryview1.py
View File

@ -18,6 +18,10 @@ try:
m[0] = 1 m[0] = 1
except TypeError: except TypeError:
print("TypeError") print("TypeError")
try:
m[0:2] = b'00'
except TypeError:
print("TypeError")
# test writing to bytearray # test writing to bytearray
b = bytearray(b) b = bytearray(b)