djsundog/circuitpython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

extmod/uzlib: Explicitly cast ptr-diff-expr to unsigned.

Browse Source 
The struct member "dest" should never be less than "destStart", so their
difference is never negative.  Cast as such to make the comparison
explicitly unsigned, ensuring the compiler produces the correct comparison
instruction, and avoiding any compiler warnings.
This commit is contained in:
Damien George 2019-12-22 22:16:32 +11:00
parent 300eb65ae7
commit ed2be79b49
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
extmod/uzlib/tinflate.c
View File

@ -464,7 +464,7 @@ static int tinf_inflate_block_data(TINF_DATA *d, TINF_TREE *lt, TINF_TREE *dt)
} }
} else { } else {
/* catch trying to point before the start of dest buffer */ /* catch trying to point before the start of dest buffer */
if (offs > d->dest - d->destStart) { if (offs > (unsigned int)(d->dest - d->destStart)) {
return TINF_DATA_ERROR; return TINF_DATA_ERROR;
} }
d->lzOff = -offs; d->lzOff = -offs;