From bc376498845a67a0348f2f7c4a73fbb55b7563bb Mon Sep 17 00:00:00 2001 From: Hierophect Date: Fri, 6 Sep 2019 11:06:02 -0400 Subject: [PATCH 1/2] Remove unused static function --- supervisor/stub/internal_flash.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/supervisor/stub/internal_flash.c b/supervisor/stub/internal_flash.c index eb1f4a106f..5db6b5bc00 100644 --- a/supervisor/stub/internal_flash.c +++ b/supervisor/stub/internal_flash.c @@ -49,10 +49,6 @@ uint32_t supervisor_flash_get_block_count(void) { void supervisor_flash_flush(void) { } -static int32_t convert_block_to_flash_addr(uint32_t block) { - return -1; -} - mp_uint_t supervisor_flash_read_blocks(uint8_t *dest, uint32_t block, uint32_t num_blocks) { return 0; // success } From 3156ee1acbd776cef5e2f09a4adbe30f4f3eed07 Mon Sep 17 00:00:00 2001 From: Hierophect Date: Fri, 6 Sep 2019 11:28:57 -0400 Subject: [PATCH 2/2] Re-apply warning as error --- ports/stm32f4/Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ports/stm32f4/Makefile b/ports/stm32f4/Makefile index 9547802d71..f3558588b6 100755 --- a/ports/stm32f4/Makefile +++ b/ports/stm32f4/Makefile @@ -105,8 +105,7 @@ endif C_DEFS += -DMCU_PACKAGE=$(MCU_PACKAGE) -#TODO: Add ASM Flags? -Werror -CFLAGS += $(INC) -Wall -std=gnu11 -nostdlib $(BASE_CFLAGS) $(C_DEFS) $(CFLAGS_MOD) $(COPT) +CFLAGS += $(INC) -Werror -Wall -std=gnu11 -nostdlib $(BASE_CFLAGS) $(C_DEFS) $(CFLAGS_MOD) $(COPT) # Undo some warnings. # STM32 apparently also uses undefined preprocessor variables quite casually,