From c4e915c3b271dd652d99fc1e1d8443cacbe8bbe2 Mon Sep 17 00:00:00 2001 From: elpekenin Date: Sat, 29 Jul 2023 14:39:44 +0200 Subject: [PATCH] Improve error message --- locale/circuitpython.pot | 2 +- shared-module/displayio/__init__.c | 2 +- tools/check_translations.py | 4 +++- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/locale/circuitpython.pot b/locale/circuitpython.pot index 1892339213..665594c1b9 100644 --- a/locale/circuitpython.pot +++ b/locale/circuitpython.pot @@ -2056,7 +2056,7 @@ msgid "Too many channels in sample." msgstr "" #: shared-module/displayio/__init__.c -msgid "Too many display busses" +msgid "Too many display busses; forgot display.release_displays() ?" msgstr "" #: shared-module/displayio/__init__.c diff --git a/shared-module/displayio/__init__.c b/shared-module/displayio/__init__.c index e9431dee14..2ec0fa7316 100644 --- a/shared-module/displayio/__init__.c +++ b/shared-module/displayio/__init__.c @@ -386,5 +386,5 @@ primary_display_bus_t *allocate_display_bus_or_raise(void) { if (result) { return result; } - mp_raise_RuntimeError(translate("Too many display busses")); + mp_raise_RuntimeError(translate("Too many display busses; forgot display.release_displays() ?")); } diff --git a/tools/check_translations.py b/tools/check_translations.py index 95776a5449..19bfa8afb0 100644 --- a/tools/check_translations.py +++ b/tools/check_translations.py @@ -22,7 +22,9 @@ for po_filename in po_filenames: missing = all_ids - po_ids if missing: - print("Missing message id. Please run `make translate`") + print( + "Missing message id. Please run `make translate` and then `git commit locale/circuitpython.pot`" + ) print(missing) sys.exit(-1) else: