djsundog/circuitpython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Also fix the read pin in the atmel and rp2040 ports

Browse Source
This commit is contained in:
Radomir Dopieralski 2022-03-06 11:33:07 +01:00
parent b5ad78715c
commit b69a06b2ed
2 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
ports/atmel-samd/common-hal/paralleldisplay/ParallelBus.c
View File

@ -69,9 +69,13 @@ void common_hal_paralleldisplay_parallelbus_construct(paralleldisplay_parallelbu
common_hal_digitalio_digitalinout_construct(&self->write, write); common_hal_digitalio_digitalinout_construct(&self->write, write);
common_hal_digitalio_digitalinout_switch_to_output(&self->write, true, DRIVE_MODE_PUSH_PULL); common_hal_digitalio_digitalinout_switch_to_output(&self->write, true, DRIVE_MODE_PUSH_PULL);
self->read.base.type = &digitalio_digitalinout_type; self->read.base.type = &mp_type_NoneType;
common_hal_digitalio_digitalinout_construct(&self->read, read); if (read != NULL) {
common_hal_digitalio_digitalinout_switch_to_output(&self->read, true, DRIVE_MODE_PUSH_PULL); self->read.base.type = &digitalio_digitalinout_type;
common_hal_digitalio_digitalinout_construct(&self->read, read);
common_hal_digitalio_digitalinout_switch_to_output(&self->read, true, DRIVE_MODE_PUSH_PULL);
never_reset_pin_number(read->number);
}
self->data0_pin = data_pin; self->data0_pin = data_pin;
self->write_group = &PORT->Group[write->number / 32]; self->write_group = &PORT->Group[write->number / 32];
@ -89,7 +93,6 @@ void common_hal_paralleldisplay_parallelbus_construct(paralleldisplay_parallelbu
never_reset_pin_number(command->number); never_reset_pin_number(command->number);
never_reset_pin_number(chip_select->number); never_reset_pin_number(chip_select->number);
never_reset_pin_number(write->number); never_reset_pin_number(write->number);
never_reset_pin_number(read->number);
for (uint8_t i = 0; i < 8; i++) { for (uint8_t i = 0; i < 8; i++) {
never_reset_pin_number(data_pin + i); never_reset_pin_number(data_pin + i);
} }

19
ports/raspberrypi/common-hal/paralleldisplay/ParallelBus.c
View File

@ -67,9 +67,13 @@ void common_hal_paralleldisplay_parallelbus_construct(paralleldisplay_parallelbu
common_hal_digitalio_digitalinout_construct(&self->chip_select, chip_select); common_hal_digitalio_digitalinout_construct(&self->chip_select, chip_select);
common_hal_digitalio_digitalinout_switch_to_output(&self->chip_select, true, DRIVE_MODE_PUSH_PULL); common_hal_digitalio_digitalinout_switch_to_output(&self->chip_select, true, DRIVE_MODE_PUSH_PULL);
self->read.base.type = &digitalio_digitalinout_type; self->read.base.type = &mp_type_NoneType;
common_hal_digitalio_digitalinout_construct(&self->read, read); if (read != NULL) {
common_hal_digitalio_digitalinout_switch_to_output(&self->read, true, DRIVE_MODE_PUSH_PULL); self->read.base.type = &digitalio_digitalinout_type;
common_hal_digitalio_digitalinout_construct(&self->read, read);
common_hal_digitalio_digitalinout_switch_to_output(&self->read, true, DRIVE_MODE_PUSH_PULL);
never_reset_pin_number(read->number);
}
self->data0_pin = data_pin; self->data0_pin = data_pin;
self->write = write_pin; self->write = write_pin;
@ -86,7 +90,6 @@ void common_hal_paralleldisplay_parallelbus_construct(paralleldisplay_parallelbu
never_reset_pin_number(command->number); never_reset_pin_number(command->number);
never_reset_pin_number(chip_select->number); never_reset_pin_number(chip_select->number);
never_reset_pin_number(write_pin); never_reset_pin_number(write_pin);
never_reset_pin_number(read->number);
for (uint8_t i = 0; i < 8; i++) { for (uint8_t i = 0; i < 8; i++) {
never_reset_pin_number(data_pin + i); never_reset_pin_number(data_pin + i);
} }
@ -121,8 +124,12 @@ void common_hal_paralleldisplay_parallelbus_deinit(paralleldisplay_parallelbus_o
reset_pin_number(self->command.pin->number); reset_pin_number(self->command.pin->number);
reset_pin_number(self->chip_select.pin->number); reset_pin_number(self->chip_select.pin->number);
reset_pin_number(self->write); reset_pin_number(self->write);
reset_pin_number(self->read.pin->number); if (self->read.base.type != &mp_type_NoneType) {
reset_pin_number(self->reset.pin->number); reset_pin_number(self->read.pin->number);
}
if (self->reset.base.type != &mp_type_NoneType) {
reset_pin_number(self->reset.pin->number);
}
} }
bool common_hal_paralleldisplay_parallelbus_reset(mp_obj_t obj) { bool common_hal_paralleldisplay_parallelbus_reset(mp_obj_t obj) {