djsundog/circuitpython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

objtype: Comments for duplicating code in runtime.c.

Browse Source
This commit is contained in:
Paul Sokolovsky 2014-05-10 21:10:19 +03:00
parent 1a7403bb74
commit aa4d19a05c
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
py/objtype.c
View File

@ -121,11 +121,13 @@ STATIC void mp_obj_class_lookup(mp_obj_instance_t *o, const mp_obj_type_t *type,
if (o != MP_OBJ_NULL && is_native_type(type)) { if (o != MP_OBJ_NULL && is_native_type(type)) {
dest[1] = o->subobj[0]; dest[1] = o->subobj[0];
} }
// TODO: Sensibly, we should call instance_convert_return_attr() here,
// instead of multiple places later. Also, this code duplicates runtime.c much.
return; return;
} }
} }
// Try this for completeness, by all native methods should be statically defined // Try this for completeness, but all native methods should be statically defined
// in locals_dict, and would be handled by above. // in locals_dict, and would be handled by above.
if (o != MP_OBJ_NULL && is_native_type(type)) { if (o != MP_OBJ_NULL && is_native_type(type)) {
mp_load_method_maybe(o->subobj[0], attr, dest); mp_load_method_maybe(o->subobj[0], attr, dest);