From aa4d19a05cdcdb4523c1a795e80a1e842e8f9a97 Mon Sep 17 00:00:00 2001 From: Paul Sokolovsky Date: Sat, 10 May 2014 21:10:19 +0300 Subject: [PATCH] objtype: Comments for duplicating code in runtime.c. --- py/objtype.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/py/objtype.c b/py/objtype.c index 460e0b2758..345eee7140 100644 --- a/py/objtype.c +++ b/py/objtype.c @@ -121,11 +121,13 @@ STATIC void mp_obj_class_lookup(mp_obj_instance_t *o, const mp_obj_type_t *type, if (o != MP_OBJ_NULL && is_native_type(type)) { dest[1] = o->subobj[0]; } + // TODO: Sensibly, we should call instance_convert_return_attr() here, + // instead of multiple places later. Also, this code duplicates runtime.c much. return; } } - // Try this for completeness, by all native methods should be statically defined + // Try this for completeness, but all native methods should be statically defined // in locals_dict, and would be handled by above. if (o != MP_OBJ_NULL && is_native_type(type)) { mp_load_method_maybe(o->subobj[0], attr, dest);