djsundog/circuitpython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

nrf: Fix missing LED GPIO initialization

Browse Source 
led_init was never called, which means the GPIOs were never set to
output and the LEDs didn't work.
This commit is contained in:
arturo182 2018-02-03 13:45:18 +01:00
parent 7c6adaa661
commit a64b5c84de
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ports/nrf/modules/machine/led.c
View File

@ -63,13 +63,6 @@ STATIC const pyb_led_obj_t pyb_led_obj[] = {
#define NUM_LEDS MP_ARRAY_SIZE(pyb_led_obj) #define NUM_LEDS MP_ARRAY_SIZE(pyb_led_obj)
void led_init(void) {
for (uint8_t i = 0; i < NUM_LEDS; i++) {
LED_OFF(pyb_led_obj[i].hw_pin);
hal_gpio_cfg_pin(0, pyb_led_obj[i].hw_pin, HAL_GPIO_MODE_OUTPUT, HAL_GPIO_PULL_DISABLED);
}
}
void led_state(pyb_led_obj_t * led_obj, int state) { void led_state(pyb_led_obj_t * led_obj, int state) {
if (state == 1) { if (state == 1) {
LED_ON(led_obj->hw_pin); LED_ON(led_obj->hw_pin);
@ -108,6 +101,9 @@ STATIC mp_obj_t led_obj_make_new(const mp_obj_type_t *type, size_t n_args, size_
nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError, "LED(%d) does not exist", led_id)); nlr_raise(mp_obj_new_exception_msg_varg(&mp_type_ValueError, "LED(%d) does not exist", led_id));
} }
hal_gpio_cfg_pin(0, pyb_led_obj[led_id - 1].hw_pin, HAL_GPIO_MODE_OUTPUT, HAL_GPIO_PULL_DISABLED);
LED_OFF(pyb_led_obj[led_id - 1].hw_pin);
// return static led object // return static led object
return (mp_obj_t)&pyb_led_obj[led_id - 1]; return (mp_obj_t)&pyb_led_obj[led_id - 1];
} }