djsundog/circuitpython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Removing erroneous else statements

Browse Source
This commit is contained in:
Max Holliday 2020-05-09 12:03:26 -07:00
parent 9ef28d8536
commit 9e01bb2136
1 changed files with 31 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

64
supervisor/shared/external_flash/external_flash.c
View File

@ -131,31 +131,30 @@ static bool page_erased(uint32_t sector_address) {
if (flash_device->no_erase_cmd){ if (flash_device->no_erase_cmd){
// skip this if device doesn't have an erase command. // skip this if device doesn't have an erase command.
return true; return true;
} else {
uint8_t short_buffer[4];
if (read_flash(sector_address, short_buffer, 4)) {
for (uint16_t i = 0; i < 4; i++) {
if (short_buffer[i] != 0xff) {
return false;
}
}
} else {
return false;
}
// Now check the full length.
uint8_t full_buffer[FILESYSTEM_BLOCK_SIZE];
if (read_flash(sector_address, full_buffer, FILESYSTEM_BLOCK_SIZE)) {
for (uint16_t i = 0; i < FILESYSTEM_BLOCK_SIZE; i++) {
if (short_buffer[i] != 0xff) {
return false;
}
}
} else {
return false;
}
return true;
} }
uint8_t short_buffer[4];
if (read_flash(sector_address, short_buffer, 4)) {
for (uint16_t i = 0; i < 4; i++) {
if (short_buffer[i] != 0xff) {
return false;
}
}
} else {
return false;
}
// Now check the full length.
uint8_t full_buffer[FILESYSTEM_BLOCK_SIZE];
if (read_flash(sector_address, full_buffer, FILESYSTEM_BLOCK_SIZE)) {
for (uint16_t i = 0; i < FILESYSTEM_BLOCK_SIZE; i++) {
if (short_buffer[i] != 0xff) {
return false;
}
}
} else {
return false;
}
return true;
} }
// Erases the given sector. Make sure you copied all of the data out of it you // Erases the given sector. Make sure you copied all of the data out of it you
@ -166,16 +165,15 @@ static bool erase_sector(uint32_t sector_address) {
if (flash_device->no_erase_cmd){ if (flash_device->no_erase_cmd){
// skip this if device doesn't have an erase command. // skip this if device doesn't have an erase command.
return true; return true;
} else { }
if (!wait_for_flash_ready() || !write_enable()) { if (!wait_for_flash_ready() || !write_enable()) {
return false; return false;
} }
if (flash_device->no_erase_cmd) { if (flash_device->no_erase_cmd) {
return true;
} else {
spi_flash_sector_command(CMD_SECTOR_ERASE, sector_address);
return true; return true;
} } else {
spi_flash_sector_command(CMD_SECTOR_ERASE, sector_address);
return true;
} }
} }