djsundog/circuitpython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

stmhal: uart ioctl uses EINVAL, and checks TXE bit for write-ability.

Browse Source
This commit is contained in:
Damien George 2014-09-07 20:57:18 +01:00
parent 013d53c0b4
commit 5c00757a5c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
stmhal/uart.c
View File

@ -27,6 +27,7 @@
#include <stdio.h> #include <stdio.h>
#include <string.h> #include <string.h>
#include <stdarg.h> #include <stdarg.h>
#include <errno.h>
#include "stm32f4xx_hal.h" #include "stm32f4xx_hal.h"
@ -488,12 +489,11 @@ mp_uint_t uart_ioctl(mp_obj_t self_in, mp_uint_t request, int *errcode, ...) {
if ((flags & MP_IOCTL_POLL_RD) && uart_rx_any(self)) { if ((flags & MP_IOCTL_POLL_RD) && uart_rx_any(self)) {
ret |= MP_IOCTL_POLL_RD; ret |= MP_IOCTL_POLL_RD;
} }
if (flags & MP_IOCTL_POLL_WR) { if ((flags & MP_IOCTL_POLL_WR) && __HAL_UART_GET_FLAG(&self->uart, UART_FLAG_TXE)) {
// TODO can we always write?
ret |= MP_IOCTL_POLL_WR; ret |= MP_IOCTL_POLL_WR;
} }
} else { } else {
*errcode = 1; // EPERM, operation not permitted *errcode = EINVAL;
ret = -1; ret = -1;
} }
va_end(vargs); va_end(vargs);