djsundog/circuitpython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

background_callback: Avoid CALLBACK_CRITICAL_BEGIN with nothing to do

Browse Source 
CALLBACK_CRITICAL_BEGIN is heavyweight, but we can be confident we do
not have work to do as long as callback_head is NULL.

This gives back performance on nRF.
This commit is contained in:
Jeff Epler 2020-07-10 14:42:21 -05:00
parent af520729fe
commit 36b4646516
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
supervisor/shared/background_callback.c
View File

@ -61,8 +61,11 @@ void background_callback_add(background_callback_t *cb, background_callback_fun
static bool in_background_callback; static bool in_background_callback;
void background_callback_run_all() { void background_callback_run_all() {
if (!callback_head) {
return;
}
CALLBACK_CRITICAL_BEGIN; CALLBACK_CRITICAL_BEGIN;
if(in_background_callback) { if (in_background_callback) {
CALLBACK_CRITICAL_END; CALLBACK_CRITICAL_END;
return; return;
} }