extmod/modurandom: Add error message when getrandbits has bad value.
The random module's getrandbits() method didn't give a proper error message when calling it with a value that was outside of the range of 1-32, which can lead to confusion using this function (which under CPython can accept numbers larger than 32). Now instead of simply giving a ValueError it gives an error message that states that the number of bits is constrained. Also, since the random module's functions getrandbits() and randint() differ from CPython, tests have been added to describe these differences. For getrandbits the relevant documentation is shown and added to the docs. The same is given for randint method so that the information is more easily found. Finally, since the int object lacks the bit_length() method there is a test for that method also to include within the docs, showing the difference to CPython.
This commit is contained in:
parent
025e4b6fbc
commit
34d4dab683
@ -88,7 +88,7 @@ STATIC uint32_t yasmarang_randbelow(uint32_t n) {
|
||||
STATIC mp_obj_t mod_urandom_getrandbits(mp_obj_t num_in) {
|
||||
int n = mp_obj_get_int(num_in);
|
||||
if (n > 32 || n == 0) {
|
||||
mp_raise_ValueError(NULL);
|
||||
mp_raise_ValueError(MP_ERROR_TEXT("bits must be 32 or less"));
|
||||
}
|
||||
uint32_t mask = ~0;
|
||||
// Beware of C undefined behavior when shifting by >= than bit size
|
||||
|
12
tests/cpydiff/modules_random_getrandbits.py
Normal file
12
tests/cpydiff/modules_random_getrandbits.py
Normal file
@ -0,0 +1,12 @@
|
||||
"""
|
||||
categories: Modules,random
|
||||
description: ``getrandbits`` method can only return a maximum of 32 bits at a time.
|
||||
cause: PRNG's internal state is only 32bits so it can only return a maximum of 32 bits of data at a time.
|
||||
workaround: If you need a number that has more than 32 bits then utilize the random module from micropython-lib.
|
||||
"""
|
||||
|
||||
import random
|
||||
|
||||
|
||||
x = random.getrandbits(64)
|
||||
print("{}".format(x))
|
12
tests/cpydiff/modules_random_randint.py
Normal file
12
tests/cpydiff/modules_random_randint.py
Normal file
@ -0,0 +1,12 @@
|
||||
"""
|
||||
categories: Modules,random
|
||||
description: ``randint`` method can only return an integer that is at most the native word size.
|
||||
cause: PRNG is only able to generate 32 bits of state at a time. The result is then cast into a native sized int instead of a full int object.
|
||||
workaround: If you need integers larger than native wordsize use the random module from micropython-lib.
|
||||
"""
|
||||
|
||||
import random
|
||||
|
||||
|
||||
x = random.randint(2 ** 128 - 1, 2 ** 128)
|
||||
print("x={}".format(x))
|
9
tests/cpydiff/types_int_bit_length.py
Normal file
9
tests/cpydiff/types_int_bit_length.py
Normal file
@ -0,0 +1,9 @@
|
||||
"""
|
||||
categories: Types,int
|
||||
description: ``bit_length`` method doesn't exist.
|
||||
cause: bit_length method is not implemented.
|
||||
workaround: Avoid using this method on MicroPython.
|
||||
"""
|
||||
|
||||
x = 255
|
||||
print("{} is {} bits long.".format(x, x.bit_length()))
|
Loading…
Reference in New Issue
Block a user