From 2fc372b9e198182419f6ca62a97ca5af4bc18982 Mon Sep 17 00:00:00 2001 From: durapensa <50685483+durapensa@users.noreply.github.com> Date: Fri, 3 Sep 2021 15:10:22 -0400 Subject: [PATCH] Lolin S2 Mini - Apply suggestions from code review Co-authored-by: Scott Shawcroft --- ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.h | 4 ---- ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.mk | 1 - 2 files changed, 5 deletions(-) diff --git a/ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.h b/ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.h index d7df2c80f5..f8223f674d 100644 --- a/ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.h +++ b/ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.h @@ -29,8 +29,6 @@ #define MICROPY_HW_BOARD_NAME "S2Mini" #define MICROPY_HW_MCU_NAME "ESP32S2-S2FN4R2" // from Wemos MP -// #define MICROPY_HW_NEOPIXEL (&pin_GPIO1) // no NeoPixel on S2 Mini -// #define CIRCUITPY_STATUS_LED_POWER (&pin_GPIO15) #define CIRCUITPY_BOOT_BUTTON (&pin_GPIO0) #define BOARD_USER_SAFE_MODE_ACTION translate("pressing boot button at start up.\n") @@ -43,5 +41,3 @@ #define DEFAULT_SPI_BUS_MOSI (&pin_GPIO11) // no SPI labels on S2 Mini, def from Wemos MP #define DEFAULT_SPI_BUS_MISO (&pin_GPIO9) // no SPI labels on S2 Mini, def from Wemos MP -// #define DEFAULT_UART_BUS_RX (&pin_GPIO44) // no UART pins on S2 Mini -// #define DEFAULT_UART_BUS_TX (&pin_GPIO43) // no UART pins on S2 Mini diff --git a/ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.mk b/ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.mk index d95bd2fec1..e4c7aacadd 100644 --- a/ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.mk +++ b/ports/esp32s2/boards/lolin_s2_mini/mpconfigboard.mk @@ -14,7 +14,6 @@ CIRCUITPY_ESP_FLASH_MODE=qio CIRCUITPY_ESP_FLASH_FREQ=80m CIRCUITPY_ESP_FLASH_SIZE=4MB -# CIRCUITPY_BITBANG_NEOPIXEL = 1 # no NeoPixel on S2 Mini # Include these Python libraries in firmware. FROZEN_MPY_DIRS += $(TOP)/frozen/Adafruit_CircuitPython_NeoPixel