From 15d0615d5cad430930d160a8ca3e809d7b82da32 Mon Sep 17 00:00:00 2001
From: Jim Mussared <jim.mussared@gmail.com>
Date: Tue, 13 Sep 2022 14:16:58 +1000
Subject: [PATCH] py/objmodule: Add support for __dict__.

This matches class `__dict__`, and is similarly gated on
MICROPY_CPYTHON_COMPAT. Unlike class though, because modules's globals are
actually dict instances, the result is a mutable dictionary.

This work was funded through GitHub Sponsors.

Signed-off-by: Jim Mussared <jim.mussared@gmail.com>
---
 py/objmodule.c              |  4 ++++
 tests/basics/module_dict.py | 13 +++++++++++++
 tests/import/module_dict.py | 17 +++++++++++++++++
 3 files changed, 34 insertions(+)
 create mode 100644 tests/basics/module_dict.py
 create mode 100644 tests/import/module_dict.py

diff --git a/py/objmodule.c b/py/objmodule.c
index d14a59b863..63e9fa4757 100644
--- a/py/objmodule.c
+++ b/py/objmodule.c
@@ -89,6 +89,10 @@ STATIC void module_attr(mp_obj_t self_in, qstr attr, mp_obj_t *dest) {
         mp_map_elem_t *elem = mp_map_lookup(&self->globals->map, MP_OBJ_NEW_QSTR(attr), MP_MAP_LOOKUP);
         if (elem != NULL) {
             dest[0] = elem->value;
+        #if MICROPY_CPYTHON_COMPAT
+        } else if (attr == MP_QSTR___dict__) {
+            dest[0] = MP_OBJ_FROM_PTR(self->globals);
+        #endif
         #if MICROPY_MODULE_GETATTR
         } else if (attr != MP_QSTR___getattr__) {
             elem = mp_map_lookup(&self->globals->map, MP_OBJ_NEW_QSTR(MP_QSTR___getattr__), MP_MAP_LOOKUP);
diff --git a/tests/basics/module_dict.py b/tests/basics/module_dict.py
new file mode 100644
index 0000000000..c847294f08
--- /dev/null
+++ b/tests/basics/module_dict.py
@@ -0,0 +1,13 @@
+# test __dict__ attribute of a built-in module
+# see import/module_dict.py for the equivalent test on user modules
+
+import sys
+
+if not hasattr(sys, "__dict__"):
+    print("SKIP")
+    raise SystemExit
+
+
+# dict of a built-in module (read-only)
+print(type(sys.__dict__))
+print(sys.__dict__["__name__"])
diff --git a/tests/import/module_dict.py b/tests/import/module_dict.py
new file mode 100644
index 0000000000..431d80b3b4
--- /dev/null
+++ b/tests/import/module_dict.py
@@ -0,0 +1,17 @@
+# test __dict__ attribute of a user module
+
+import sys
+
+if not hasattr(sys, "__dict__"):
+    print("SKIP")
+    raise SystemExit
+
+
+import import1b
+
+# dict of a user module (read/write)
+print(import1b.var)
+print(import1b.__dict__["var"])
+import1b.__dict__["var"] = "hello"
+print(import1b.var)
+print(import1b.__dict__["var"])