djsundog/circuitpython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

py/runtime.c: Remove optimization of '*a,=b', it caused a bug.

Browse Source 
*a, = b should always make a copy of b, instead, before this patch
if b was a list it would copy only a reference to it.
This commit is contained in:
Krzysztof Blazewicz 2017-03-06 08:46:21 +01:00 committed by Damien George
parent 88ffe0d5cc
commit 1215dc47e2
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
py/runtime.c
View File

@ -854,11 +854,6 @@ void mp_unpack_ex(mp_obj_t seq_in, size_t num_in, mp_obj_t *items) {
if (MP_OBJ_IS_TYPE(seq_in, &mp_type_tuple)) { if (MP_OBJ_IS_TYPE(seq_in, &mp_type_tuple)) {
mp_obj_tuple_get(seq_in, &seq_len, &seq_items); mp_obj_tuple_get(seq_in, &seq_len, &seq_items);
} else { } else {
if (num_left == 0 && num_right == 0) {
// *a, = b # sets a to b if b is a list
items[0] = seq_in;
return;
}
mp_obj_list_get(seq_in, &seq_len, &seq_items); mp_obj_list_get(seq_in, &seq_len, &seq_items);
} }
if (seq_len < num_left + num_right) { if (seq_len < num_left + num_right) {