diff --git a/ports/stm32f4/common-hal/analogio/AnalogOut.c b/ports/stm32f4/common-hal/analogio/AnalogOut.c index 3043893566..5eb8c2dc03 100644 --- a/ports/stm32f4/common-hal/analogio/AnalogOut.c +++ b/ports/stm32f4/common-hal/analogio/AnalogOut.c @@ -42,13 +42,13 @@ //DAC is shared between both channels. //TODO: store as struct with channel info, automatically turn it off if unused //on both channels for power save? -#if defined(HAS_DAC) +#if HAS_DAC DAC_HandleTypeDef handle; #endif void common_hal_analogio_analogout_construct(analogio_analogout_obj_t* self, const mcu_pin_obj_t *pin) { - #if !defined(HAS_DAC) + #if !(HAS_DAC) mp_raise_ValueError(translate("No DAC on chip")); #else if (pin == &pin_PA04) { @@ -93,7 +93,7 @@ bool common_hal_analogio_analogout_deinited(analogio_analogout_obj_t *self) { } void common_hal_analogio_analogout_deinit(analogio_analogout_obj_t *self) { - #if defined(HAS_DAC) + #if HAS_DAC reset_pin_number(self->pin->port,self->pin->number); self->pin = mp_const_none; self->deinited = true; @@ -103,14 +103,14 @@ void common_hal_analogio_analogout_deinit(analogio_analogout_obj_t *self) { void common_hal_analogio_analogout_set_value(analogio_analogout_obj_t *self, uint16_t value) { - #if defined(HAS_DAC) + #if HAS_DAC HAL_DAC_SetValue(&handle, self->channel, DAC_ALIGN_12B_R, value >> 4); HAL_DAC_Start(&handle, self->channel); #endif } void analogout_reset(void) { - #if defined(HAS_DAC) + #if HAS_DAC __HAL_RCC_DAC_CLK_DISABLE(); HAL_DAC_DeInit(&handle); #endif diff --git a/ports/stm32f4/common-hal/analogio/AnalogOut.h b/ports/stm32f4/common-hal/analogio/AnalogOut.h index 49ab647330..1381d4d3a7 100644 --- a/ports/stm32f4/common-hal/analogio/AnalogOut.h +++ b/ports/stm32f4/common-hal/analogio/AnalogOut.h @@ -36,7 +36,7 @@ typedef struct { mp_obj_base_t base; -#if defined(HAS_DAC) +#if HAS_DAC DAC_ChannelConfTypeDef ch_handle; #endif const mcu_pin_obj_t * pin; diff --git a/ports/stm32f4/peripherals/stm32f4/periph.h b/ports/stm32f4/peripherals/stm32f4/periph.h index 7ad59d756f..82f179147b 100644 --- a/ports/stm32f4/peripherals/stm32f4/periph.h +++ b/ports/stm32f4/peripherals/stm32f4/periph.h @@ -102,17 +102,19 @@ typedef struct { //Starter Lines #ifdef STM32F411xE +#define HAS_DAC 0 #include "stm32f411xe/periph.h" #endif #ifdef STM32F412Zx +#define HAS_DAC 0 #include "stm32f412zx/periph.h" #endif //Foundation Lines #ifdef STM32F405xx -#define HAS_DAC +#define HAS_DAC 1 #include "stm32f405xx/periph.h" #endif